/
add-command.test.js
329 lines (248 loc) · 9.7 KB
/
add-command.test.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
"use strict";
jest.mock("@lerna/bootstrap");
jest.mock("@evocateur/pacote/manifest");
// mocked or stubbed modules
const bootstrap = require("@lerna/bootstrap");
const getManifest = require("@evocateur/pacote/manifest");
// helpers
const initFixture = require("@lerna-test/init-fixture")(__dirname);
const { getPackages } = require("@lerna/project");
// file under test
const lernaAdd = require("@lerna-test/command-runner")(require("../command"));
// assertion helpers
expect.extend(require("@lerna-test/pkg-matchers"));
describe("AddCommand", () => {
// we already have enough tests of BootstrapCommand
bootstrap.mockResolvedValue();
// we don't need network requests during unit tests
getManifest.mockResolvedValue({ version: "1.0.0" });
it("should throw without packages", async () => {
expect.assertions(1);
const testDir = await initFixture("basic");
try {
await lernaAdd(testDir)();
} catch (err) {
expect(err.message).toMatch(/^Not enough non-option arguments/);
}
});
it("should throw for locally unsatisfiable version ranges", async () => {
expect.assertions(1);
const testDir = await initFixture("basic");
try {
await lernaAdd(testDir)("@test/package-1@2");
} catch (err) {
expect(err.message).toMatch(/Requested range not satisfiable:/);
}
});
it("should throw for adding local package without specified version", async () => {
expect.assertions(1);
const testDir = await initFixture("unspecified-version");
try {
await lernaAdd(testDir)("@test/package-1");
} catch (err) {
expect(err.message).toMatch(/Requested package has no version:/);
}
});
it("should reference remote dependencies", async () => {
const testDir = await initFixture("basic");
await lernaAdd(testDir)("tiny-tarball");
const [pkg1, pkg2, pkg3, pkg4] = await getPackages(testDir);
expect(pkg1).toDependOn("tiny-tarball");
expect(pkg2).toDependOn("tiny-tarball");
expect(pkg3).toDependOn("tiny-tarball");
expect(pkg4).toDependOn("tiny-tarball");
expect(getManifest).toHaveBeenLastCalledWith(
expect.objectContaining({
// an npm-package-arg Result
name: "tiny-tarball",
fetchSpec: "latest",
registry: true,
type: "tag",
}),
expect.objectContaining({
// an npm-conf snapshot
registry: "https://registry.npmjs.org/",
})
);
});
it("should reference local dependencies", async () => {
const testDir = await initFixture("basic");
await lernaAdd(testDir)("@test/package-1");
const [, pkg2, pkg3, pkg4] = await getPackages(testDir);
expect(pkg2).toDependOn("@test/package-1");
expect(pkg3).toDependOn("@test/package-1");
expect(pkg4).toDependOn("@test/package-1");
});
it("should reference current caret range if unspecified", async () => {
const testDir = await initFixture("basic");
await lernaAdd(testDir)("@test/package-1");
await lernaAdd(testDir)("@test/package-2");
const [pkg1, pkg2] = await getPackages(testDir);
expect(pkg1).toDependOn("@test/package-2", "^2.0.0");
expect(pkg2).toDependOn("@test/package-1", "^1.0.0");
});
it("should reference specified range", async () => {
const testDir = await initFixture("basic");
await lernaAdd(testDir)("@test/package-1@~1");
const [, pkg2] = await getPackages(testDir);
expect(pkg2).toDependOn("@test/package-1", "~1");
});
it("should reference exact version if --exact", async () => {
const testDir = await initFixture("basic");
await lernaAdd(testDir)("@test/package-1", "--exact");
const [, pkg2] = await getPackages(testDir);
expect(pkg2).toDependOn("@test/package-1", "1.0.0", {
exact: true,
});
});
it("adds explicit local file: specifier as file: specifier", async () => {
const testDir = await initFixture("basic");
await lernaAdd(testDir)("@test/package-1@file:packages/package-1");
const [, pkg2] = await getPackages(testDir);
expect(pkg2).toDependOn("@test/package-1", "file:../package-1");
});
it("adds local dep as file: specifier when existing relationships are file: specifiers", async () => {
const testDir = await initFixture("existing");
const [, , pkg3] = await getPackages(testDir);
pkg3.updateLocalDependency({ name: "@test/package-2", type: "directory" }, "file:../package-2", "");
await pkg3.serialize();
await lernaAdd(testDir)("@test/package-1");
const [, pkg2] = await getPackages(testDir);
expect(pkg2).toDependOn("@test/package-1", "file:../package-1");
});
it("should add target package to devDependencies", async () => {
const testDir = await initFixture("basic");
await lernaAdd(testDir)("@test/package-1", "--dev");
const [, pkg2, pkg3, pkg4] = await getPackages(testDir);
expect(pkg2).toDevDependOn("@test/package-1");
expect(pkg3).toDevDependOn("@test/package-1");
expect(pkg4).toDevDependOn("@test/package-1");
});
it("should add target package to devDependencies with alias", async () => {
const testDir = await initFixture("basic");
await lernaAdd(testDir)("-D", "@test/package-1");
const [, pkg2] = await getPackages(testDir);
expect(pkg2).toDevDependOn("@test/package-1");
});
it("should not reference packages to themeselves", async () => {
const testDir = await initFixture("basic");
await lernaAdd(testDir)("@test/package-1");
const [pkg1] = await getPackages(testDir);
expect(pkg1).not.toDependOn("@test/package-1");
});
it("filters targets by optional directory globs", async () => {
const testDir = await initFixture("basic");
await lernaAdd(testDir)("@test/package-1", "packages/package-2");
const [, pkg2, pkg3, pkg4] = await getPackages(testDir);
expect(pkg2).toDependOn("@test/package-1");
expect(pkg3).not.toDevDependOn("@test/package-1");
expect(pkg4).not.toDevDependOn("@test/package-1");
});
it("should retain existing dependencies", async () => {
const testDir = await initFixture("existing");
await lernaAdd(testDir)("@test/package-2");
const [pkg1] = await getPackages(testDir);
expect(pkg1).toDependOn("pify");
});
it("should retain existing devDependencies", async () => {
const testDir = await initFixture("existing");
await lernaAdd(testDir)("@test/package-1", "--dev");
const [, pkg2] = await getPackages(testDir);
expect(pkg2).toDevDependOn("file-url");
});
it("supports tag specifiers", async () => {
const testDir = await initFixture("basic");
await lernaAdd(testDir)("tiny-tarball@latest");
const [pkg1] = await getPackages(testDir);
expect(pkg1).toDependOn("tiny-tarball", "^1.0.0");
});
it("supports version specifiers (exact)", async () => {
const testDir = await initFixture("basic");
await lernaAdd(testDir)("tiny-tarball@1.0.0");
const [pkg1] = await getPackages(testDir);
expect(pkg1).toDependOn("tiny-tarball", "1.0.0", { exact: true });
});
it("accepts --registry option", async () => {
const testDir = await initFixture("basic");
getManifest.mockImplementationOnce(() => {
const err = new Error("ENOTFOUND");
return Promise.reject(err);
});
try {
await lernaAdd(testDir)(
"@my-own/private-idaho",
"--registry",
"http://registry.cuckoo-banana-pants.com/"
);
} catch (err) {
// obviously this registry doesn't exist, thus it will always error
expect(err.message).toMatch("ENOTFOUND");
expect(getManifest).toHaveBeenLastCalledWith(
expect.objectContaining({
name: "@my-own/private-idaho",
}),
expect.objectContaining({
registry: "http://registry.cuckoo-banana-pants.com/",
})
);
}
expect.hasAssertions();
});
it("should bootstrap changed packages", async () => {
const testDir = await initFixture("basic");
await lernaAdd(testDir)("@test/package-1");
expect(bootstrap).toHaveBeenLastCalledWith(
expect.objectContaining({
args: [],
cwd: testDir,
composed: "add",
})
);
});
it("should not pass filter options to bootstrap", async () => {
const testDir = await initFixture("existing");
await lernaAdd(testDir)(
"@test/package-2",
"--scope=@test/package-1",
"--ignore=@test/package-3",
"--no-private",
"--since=deadbeef",
"--include-filtered-dependents",
"--include-filtered-dependencies"
);
const [pkg1] = await getPackages(testDir);
expect(pkg1).toDependOn("@test/package-2");
expect(bootstrap).toHaveBeenLastCalledWith(
expect.objectContaining({
scope: undefined,
ignore: undefined,
private: undefined,
since: undefined,
excludeDependents: undefined,
includeDependents: undefined,
includeDependencies: undefined,
})
);
});
it("should not bootstrap unchanged packages", async () => {
const testDir = await initFixture("unchanged");
await lernaAdd(testDir)("@test/package-1");
expect(bootstrap).not.toHaveBeenCalled();
});
it("skips bootstrap with --no-bootstrap", async () => {
const testDir = await initFixture("basic");
await lernaAdd(testDir)("@test/package-1", "--no-bootstrap");
const [, pkg2] = await getPackages(testDir);
expect(bootstrap).not.toHaveBeenCalled();
expect(pkg2).toDependOn("@test/package-1", "^1.0.0");
});
it("should reset a dependency from caret to exact", async () => {
const testDir = await initFixture("basic");
await lernaAdd(testDir)("@test/package-1");
await lernaAdd(testDir)("@test/package-1", "--exact");
const [, pkg2] = await getPackages(testDir);
expect(pkg2).toDependOn("@test/package-1", "1.0.0", {
exact: true,
});
});
});