fix(conventional-commits): Ensure potential ValidationError in `get…

…ChangelogConfig()` is propagated correctly
lerna · Nov 19, 2019 · 406ba5a · 406ba5a
1 parent 563f995
commit 406ba5a
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/core/conventional-commits/lib/recommend-version.js b/core/conventional-commits/lib/recommend-version.js
@@ -35,7 +35,11 @@ function recommendVersion(pkg, type, { changelogPreset, rootPath, tagPrefix, pre
     }
   };
 
-  return getChangelogConfig(changelogPreset, rootPath).then(config => {
+  // Ensure potential ValidationError in getChangelogConfig() is propagated correctly
+  let chain = Promise.resolve();
+
+  chain = chain.then(() => getChangelogConfig(changelogPreset, rootPath));
+  chain = chain.then(config => {
     // "new" preset API
     options.config = config;
 
@@ -61,4 +65,6 @@ function recommendVersion(pkg, type, { changelogPreset, rootPath, tagPrefix, pre
       });
     });
   });
+
+  return chain;
 }