fix(version): Workaround yargs bug with spurious -- arguments

Fixes #2315
lerna · Oct 22, 2019 · 46be9dc · 46be9dc
1 parent 384cd15
commit 46be9dc
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/commands/version/__tests__/version-command.test.js b/commands/version/__tests__/version-command.test.js
@@ -734,4 +734,14 @@ describe("VersionCommand", () => {
       expect(changedFiles).toContain("packages/package-1/package-lock.json");
     });
   });
+
+  describe("with spurious -- arguments", () => {
+    it("ignores the extra arguments with cheesy parseConfiguration()", async () => {
+      const cwd = await initFixture("lifecycle");
+      await lernaVersion(cwd)("--yes", "--", "--loglevel", "ignored", "--blah");
+
+      const logMessages = loggingOutput("warn");
+      expect(logMessages).toContain("Arguments after -- are no longer passed to subprocess executions.");
+    });
+  });
 });
diff --git a/commands/version/command.js b/commands/version/command.js
@@ -156,6 +156,11 @@ exports.builder = (yargs, composed) => {
 
   yargs.options(opts);
 
+  // workaround yargs bug that re-interprets unknown arguments in argv._
+  yargs.parserConfiguration({
+    "populate--": true,
+  });
+
   if (!composed) {
     // hide options from composed command's help output
     yargs.group(Object.keys(opts), "Command Options:");
@@ -231,6 +236,11 @@ exports.builder = (yargs, composed) => {
       }
       /* eslint-enable no-param-reassign */
 
+      if (argv["--"]) {
+        log.warn("EDOUBLEDASH", "Arguments after -- are no longer passed to subprocess executions.");
+        log.warn("EDOUBLEDASH", "This will cause an error in a future major version.");
+      }
+
       return argv;
     });
 };