fix(run-lifecycle): Do not customize npm_config_prefix during execution

Fixes #1866
lerna · Jan 11, 2019 · 79549c1 · 79549c1
1 parent d9ac62c
commit 79549c1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/utils/run-lifecycle/__tests__/run-lifecycle.test.js b/utils/run-lifecycle/__tests__/run-lifecycle.test.js
@@ -2,6 +2,7 @@
 
 jest.mock("libnpm/run-script", () => jest.fn(() => Promise.resolve()));
 
+const log = require("libnpm/log");
 const loggingOutput = require("@lerna-test/logging-output");
 const runScript = require("libnpm/run-script");
 const npmConf = require("@lerna/npm-conf");
@@ -64,7 +65,6 @@ describe("runLifecycle()", () => {
       pkg.location,
       expect.objectContaining({
         config: expect.objectContaining({
-          prefix: pkg.location,
           "custom-cli-flag": true,
         }),
         dir: pkg.location,
@@ -89,8 +89,8 @@ describe("runLifecycle()", () => {
     const opts = new Map([
       ["ignore-prepublish", true],
       ["ignore-scripts", false],
-      ["node-options", true],
-      ["script-shell", true],
+      ["node-options", "--a-thing"],
+      ["script-shell", "fish"],
       ["scripts-prepend-node-path", true],
       ["unsafe-perm", false],
     ]);
@@ -99,13 +99,14 @@ describe("runLifecycle()", () => {
 
     expect(runScript).toHaveBeenLastCalledWith(expect.objectContaining(pkg), stage, dir, {
       config: expect.objectContaining({
-        prefix: dir,
+        "node-options": "--a-thing",
+        "script-shell": "fish",
       }),
       dir,
       failOk: false,
-      log: expect.any(Object),
-      nodeOptions: true,
-      scriptShell: true,
+      log,
+      nodeOptions: "--a-thing",
+      scriptShell: "fish",
       scriptsPrependNodePath: true,
       unsafePerm: false,
     });

diff --git a/utils/run-lifecycle/run-lifecycle.js b/utils/run-lifecycle/run-lifecycle.js
@@ -74,9 +74,6 @@ function runLifecycle(pkg, stage, _opts) {
     }
   }
 
-  // env.npm_config_prefix should be the package directory
-  config.prefix = dir;
-
   /* istanbul ignore else */
   // eslint-disable-next-line no-underscore-dangle
   if (pkg.__isLernaPackage) {