fix(collect-updates): Match dotfiles when ignoring changes

lerna · Feb 6, 2019 · 99eadc6 · 99eadc6
1 parent 2105000
commit 99eadc6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/utils/collect-updates/__tests__/lib-make-diff-predicate.test.js b/utils/collect-updates/__tests__/lib-make-diff-predicate.test.js
@@ -60,6 +60,7 @@ test("rooted package", () => {
 
 test("ignore changes (globstars)", () => {
   setup([
+    "packages/pkg-2/examples/.eslintrc.yaml",
     "packages/pkg-2/examples/do-a-thing/index.js",
     "packages/pkg-2/examples/and-another-thing/package.json",
   ]);

diff --git a/utils/collect-updates/lib/make-diff-predicate.js b/utils/collect-updates/lib/make-diff-predicate.js
@@ -13,6 +13,8 @@ function makeDiffPredicate(committish, execOpts, ignorePatterns = []) {
     ignorePatterns.map(p =>
       minimatch.filter(`!${p}`, {
         matchBase: true,
+        // dotfiles inside ignored directories should also match
+        dot: true,
       })
     )
   );