fix(cli): Ensure exit code is always numeric

lerna · Jan 22, 2019 · a2362b8 · andysmith415 · Jan 29, 2019 · evocateur
1 parent d0ff473
commit a2362b8
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/core/cli/__tests__/core-cli.test.js b/core/cli/__tests__/core-cli.test.js
@@ -159,6 +159,27 @@ describe("core-cli", () => {
     );
   });
 
+  it("coerces string exit codes to 1", async () => {
+    const cli = prepare(cwd);
+    const spy = jest.spyOn(cli, "exit");
+
+    cli.command("errname", "a string code", {}, async () => {
+      const err = new Error("npm-registry-fetch");
+      err.code = "E401";
+      throw err;
+    });
+
+    // paradoxically, this does NOT reject...
+    await parse(cli, ["errname"]);
+
+    expect(spy).toHaveBeenLastCalledWith(
+      1,
+      expect.objectContaining({
+        message: "npm-registry-fetch",
+      })
+    );
+  });
+
   it("preserves exotic exit codes", async () => {
     const cli = prepare(cwd);
     const spy = jest.spyOn(cli, "exit");

diff --git a/core/cli/index.js b/core/cli/index.js
@@ -37,7 +37,7 @@ function lernaCLI(argv, cwd) {
       }
 
       // exit non-zero so the CLI can be usefully chained
-      cli.exit(actual.code || 1, actual);
+      cli.exit(actual.code > 0 ? actual.code : 1, actual);
     })
     .alias("h", "help")
     .alias("v", "version")