fix(publish): Skip private package lookup (#1905)

commands/publish/__tests__/__fixtures__/public-private/LICENSE

@@ -0,0 +1,3 @@
+Copyright (c) 2018 Tester McPerson <test@example.com>
+
+ABC License

commands/publish/__tests__/__fixtures__/public-private/lerna.json

@@ -0,0 +1,3 @@
+{
+  "version": "1.0.0"
+}

commands/publish/__tests__/__fixtures__/public-private/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "licenses",
+  "version": "0.0.0-monorepo"
+}

commands/publish/__tests__/__fixtures__/public-private/packages/package-1/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "package-1",
+  "version": "1.0.0"
+}

commands/publish/__tests__/__fixtures__/public-private/packages/package-2/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "package-2",
+  "version": "1.0.0",
+  "private": true
+}

commands/publish/__tests__/get-unpublished-packages.test.js

@@ -68,3 +68,23 @@ Array [
 ]
 `);
 });
+
+test("getUnpublishedPackages with private package", async () => {
+  const cwd = await initFixture("public-private");
+  const packages = await getPackages(cwd);
+  const packageGraph = new PackageGraph(packages);
+
+  const opts = new Map();
+  const pkgs = await getUnpublishedPackages(packageGraph, opts);
+
+  expect(pkgs).toMatchInlineSnapshot(`
+Array [
+  PackageGraphNode {
+    "externalDependencies": Map {},
+    "localDependencies": Map {},
+    "localDependents": Map {},
+    "name": "package-1",
+  },
+]
+`);
+});

commands/publish/lib/get-unpublished-packages.js

@@ -11,6 +11,9 @@ function getUnpublishedPackages(packageGraph, opts) {
 
   let chain = Promise.resolve();
 
+  // don't bother attempting to get the packument for private packages
+  const graphNodesToCheck = Array.from(packageGraph.values()).filter(({ pkg }) => !pkg.private);
+
   const mapper = pkg =>
     getPackument(pkg.name, opts).then(
       packument => {
@@ -24,7 +27,7 @@ function getUnpublishedPackages(packageGraph, opts) {
       }
     );
 
-  chain = chain.then(() => pMap(packageGraph.values(), mapper, { concurrency: 4 }));
+  chain = chain.then(() => pMap(graphNodesToCheck, mapper, { concurrency: 4 }));
 
   return chain.then(results => results.filter(Boolean));
 }