lerna publish --independent triggering publish also for packages that haven't changed

[marcofugaro]

When I run lerna publish --independent, lerna is asking me to publish also the packages that I haven't touched, and there is no way for me to skip the publishing of those.

From the readme:

Each time you publish, you will get a prompt for each package that has changed to specify if it's a patch, minor, major or custom change.

Expected Behavior

It should prompt me to publish only the packages that have changed.

Current Behavior

It prompts the publish for every package.

Steps to Reproduce (for bugs)

This is the repo where this happens

lerna.json

{
  "lerna": "2.1.2",
  "version": "independent",
  "npmClient": "yarn",
  "useWorkspaces": true
}

Your Environment

Executable	Version
lerna --version	2.1.2
npm --version	6.0.1
yarn --version	1.6.0
node --version	10.1.0

OS	Version
macOS High Sierra	10.13.4

[doug-wade]

Do they depend on a package which has changed?

[marcofugaro]

Nope, I didn't touch the dependencies either

[evocateur]

What does lerna diff report?

[marcofugaro]

@evocateur right now only this

after I committed some changes to the package accurapp-scripts, the lerna diff is showing me the changed lines only of the files inside accurapp-scripts I changed, and nothing else.

I tried to publish again after this, and it still prompts for every other package also.

[evocateur]

If every other local package depends on that package, they will also be bumped (because lerna bumps the dependency range of the package with changes). This is how lerna works.

…

On May 24, 2018, at 03:13, Marco Fugaro ***@***.***> wrote: @evocateur right now only this after I committed some changes to the package accurapp-scripts, the lerna diff is showing me the changed lines only of the files inside accurapp-scripts I changed, nothing else. I tried to publish again after this, and it still prompts for every other package also. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[marcofugaro]

Except they don't, take for example the package eslint-config-accurapp, these are its dependencies:

None of its dependencies is another package.

And this is lerna asking me to publish it, even if it isn't in the lerna diff:

[evocateur]

All I can think of is that your tags are missing, somehow, and lerna thinks it has to publish everything. Might be because you last published on a branch that was then merged into master, which corrupts the tag references.

[marcofugaro]

Hmm interesting, might be, how can I try to fix it? By removing the tags?

[evocateur]

No, by ensuring that the tags exist, are reachable from your current HEAD, and such. `git describe` is an easy way to test “reachability.” If the tags are missing or mangled, you’ll need to restore them (as annotated tags) on the master branch. Then lerna will properly ignore packages that have not changed since the last release (annotated git tag).

…

On May 25, 2018, at 07:46, Marco Fugaro ***@***.***> wrote: Hmm interesting, might be, how can I try to fix it? By removing the tags? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[marcofugaro]

@evocateur Thank you! I will check the tags.

Does lerna need EVERY past publish tags to be changed, or just the latest ones? Because the latest ones are already present in the same branch I'm publishing from (not master)

[evocateur]

As long as the most recent reachable tag is annotated (not lightweight), that’s all you need.

…

On May 29, 2018, at 08:04, Marco Fugaro ***@***.***> wrote: @evocateur Thank you! I will check the tags. Does lerna need EVERY past publish tags to be changed, or just the latest ones? Because the latest ones are already present in the same branch I'm publishing from (not master) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[marcofugaro]

Alright man, I checked the tags using this script and turns out the latest tags are actually annotated. Also I made sure they're on the same branch I am in.

I went ahead and made a diff for the latest tag and the current HEAD, only for one package, like this:

git diff eslint-config-accurapp@4.1.0-beta.2..HEAD packages/eslint-config-accurapp/

And it outputs nothing because nothing has actually changed.

I don't know what else to do man, I provided you with the repo where this happens and the specific branch, if you wish to debug. Thanks for your help!

[kevinbarabash]

Is this not a duplicate of #1357?

[marcofugaro]

Yup, I think so

[lock]

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.