Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lerna bootstrap --hoist fails in CI with npm ci #1865

Closed
coreyfarrell opened this issue Jan 10, 2019 · 2 comments
Closed

lerna bootstrap --hoist fails in CI with npm ci #1865

coreyfarrell opened this issue Jan 10, 2019 · 2 comments

Comments

@coreyfarrell
Copy link

Expected Behavior

No errors from npm ci.

Current Behavior

istanbuljs/istanbuljs#269 fails travis-ci in node.js 8. lerna ^2.11.0 is known to work correctly.

See https://travis-ci.org/istanbuljs/istanbuljs/builds/478060155

Steps to Reproduce (for bugs)

See PR.

  1. Upgrade lerna from 2.x to 3.x, update package-lock.json to match.
  2. Submit PR with travis-ci enabled for node.js 8.
lerna.json

{
  "lerna": "3.10.3",
  "packages": [
    "packages/*"
  ],
  "version": "independent"
}

Context

This blocks istanbul from updating to lerna@3.

Your Environment

Executable Version
lerna --version 3.10.3
npm --version 6.4.1
node --version 8.15.0
OS Version
NAME VERSION
Ubuntu Ubuntu 14.04.5 LTS
@evocateur
Copy link
Member

If you want to use npm ci with a lockfile of the entire tree, you need to call npx lerna link convert once and stop using lerna bootstrap.

A much smaller workaround is to add --no-ci to the lerna bootstrap --hoist call. (I could have sworn we already disabled the use of npm ci internally when bootstrap was called with --hoist...)

@evocateur evocateur changed the title lerna 3.x causing npm ci to fail under node.js 8. lerna bootstrap --hoist fails in CI with npm ci Jan 10, 2019
@lock
Copy link

lock bot commented Apr 10, 2019

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants