fix(import): Ensure compatibility with root-level package globs

[wavebeem]

Fixes lerna import to work in the case where packages are housed at the root level of a lerna-managed repo and use a configuration like ["myapp-*"] for the packages configuration.

Description

I changed the getPackageDirectories() method inside the import command so that any path ending in * is considered a package root location instead of just the ones ending in /*.

Motivation and Context

This fixes #1872. The change makes it possible to use lerna import when your packages are located at the root directory of a lerna-managed repo.

How Has This Been Tested?

I added a new test that covers the exact case failing in the issue I reported. The test makes a new lerna repo with the myapp-* config, imports a subpackage, and then verifies the new history and file contents.

I had to add a new testing helper since having a static name for the test repo wasn't supported by the regular fixtures helper function.

I wrote the test before the implementation, verified it failed, wrote the implementation, and verified both manually and through the test code that everything is working correctly.

I ran npm test to test the code.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

I would imagine this is just a bug fix, not a breaking change, but I wouldn't know for sure.

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

I don't think the existing documentation needs to be updated. I expected this to work already based on it.

Note:

It's possibly outside the scope of this ticket, but the output of this error is hard to read when there are zero package directories since JS stringifies an empty array to empty string:

throw new ValidationError(
  "EDESTDIR",
  `--dest does not match with the package directories: ${this.getPackageDirectories()}`
);

[evocateur]

Looks great, thanks!

[lock]

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.