New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not increment version if a devDep + peerDep? #1898
Comments
Yeah, this seems fair. I think we've long yearned for some sort of distinction between |
Is this related to #1737? |
@diegohaz Yes, this is essentially what I was agreeing with you in that thread. Potential pitfalls, off the top of my head:
|
Hello, I have a similar issue on my end. I have a devDependency that generates some code and this code is reexported by several packages. I wish there was a mechanism to specify how the version change of one package affects the rest. E.g. somewhere in lerna confg to specify that MAJOR bump in foo would lead to MAJOR bump of baz. Something like:
And that would basically mean that if lerna version figures out that "baz" was affected by "major" it should bump the version of "foo" with a "major". And if the version of "baz" was affected by a "major" change it would bump "bar" with just a "patch". And there may be few semantic one-liner options like:
|
Is this dead? |
Say we have packages
foo
,bar
, andbaz
, withbar
andbaz
havingfoo
as a peer dependency. Both of these packages also have a dev dependency forfoo
so that npm/yarn install/symlink everything correctly.Now, when
foo
is updated and I runlerna publish
, it increments thefoo
dev dependency inbar
andbaz
(even when they haven't been modified), which causes a patch version to be published for these 2 packages. These patch versions are completely unnecessary.It would be nice to avoid this if possible, possibly through a CLI flag.
Expected Behavior
N/A, not sure it's scoped.
Current Behavior
It unnecessarily releases versions when
devDeps
are updated.Possible Solution
Disable through a CLI flag? Don't increment
devDep
if also apeerDep
?Context
This is causing unnecessary patch releases for packages.
Your Environment
lerna --version
npm --version
yarn --version
node --version
The text was updated successfully, but these errors were encountered: