Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publish): Skip private package lookup #1905

Merged
merged 2 commits into from Jan 31, 2019
Merged

fix(publish): Skip private package lookup #1905

merged 2 commits into from Jan 31, 2019

Conversation

pshrmn
Copy link
Contributor

@pshrmn pshrmn commented Jan 30, 2019

Skip checking if a private package's current version is published since private packages are never published.

Description

Filters out packages whose private value is false.

Motivation and Context

#1890

How Has This Been Tested?

I added a fixture with two packages, one public and one private and verify that only the public package shows up in the output from getUnpublishedPackages.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@evocateur evocateur changed the title feat(publish): Skip private package lookup fix(publish): Skip private package lookup Jan 31, 2019
evocateur
evocateur approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks!

@evocateur evocateur merged commit f9e18fa into lerna:master Jan 31, 2019
@pshrmn
Copy link
Contributor Author

pshrmn commented Jan 31, 2019

Thanks for the outline in the issue. You made it so simple that I would have felt guilty not submitting a PR!

@pshrmn pshrmn deleted the skip-private-publish-check branch January 31, 2019 19:15
@lock
Copy link

lock bot commented Apr 1, 2019

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evocateur evocateur evocateur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pshrmn @evocateur