Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag-version-prefix is not documented #1924

Closed
kirill-konshin opened this issue Feb 11, 2019 · 3 comments · Fixed by #2035
Closed

tag-version-prefix is not documented #1924

kirill-konshin opened this issue Feb 11, 2019 · 3 comments · Fixed by #2035

Comments

@kirill-konshin
Copy link
Contributor

kirill-konshin commented Feb 11, 2019

Argument tag-version-prefix is not documented except in version command's help: https://github.com/lerna/lerna/blob/f84a631402d37b67053f6c1196e6bdf1eccaae05/commands/version/command.js

But in fact it should be used twice in some cases like this one:

#locally
lerna version --tag-version-prefix=''
#on ci
lerna publish from-git --tag-version-prefix='' 

I suggest to add this to lerna.json config for consistency.

@evocateur
Copy link
Member

Yes, we definitely should document that in https://github.com/lerna/lerna/blob/master/commands/version/README.md

@stale
Copy link

stale bot commented Apr 12, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@kirill-konshin
Copy link
Contributor Author

Thanks, stale bot :) lol, I've pushed the PR for this.

Still, I suggest to introduce a lerna.json option for this in order to get rid of duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants