Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(import): Avoid "unrecognized input" error from colors when using --flatten #2037

Merged
merged 1 commit into from Apr 17, 2019

Conversation

fc
Copy link
Contributor

@fc fc commented Apr 12, 2019

Resolves issue when color in the output would create invalid output

Description

Motivation and Context

Resolves the same or similar problem described here:
#1644

Basically, calling git log would contain colorized output that leads to problems when calling git am ...

Note: It resolves only when the --flatten parameter is set!

Kudos to random StackOverflow dude who pointed me in the direction of the right fix:
https://stackoverflow.com/a/53191568/747678

How Has This Been Tested?

I checked out the lerna repos locally, made the change, used npm link and ran lerna import --flatten some-dir that way to see the import worked successfully. Also ran integration test npm run integration -- lerna-import.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Resolves issue when color in the output would create invalid output
@evocateur evocateur changed the title Fix "unrecognized input" error when executing lerna import --flatten fix(import): Avoid "unrecognized input" error from colors when using --flatten Apr 17, 2019
Copy link
Member

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evocateur evocateur merged commit 51625fa into lerna:master Apr 17, 2019
@fc fc deleted the patch-2 branch April 22, 2019 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants