feat(publish): display uncommitted changes in check-working-tree #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdeona
force-pushed
the
master
branch
9 times, most recently
from
99e8f8a
to
3cf26c5
Compare
… utils/collect-uncommitted
evocateur
approved these changes
May 11, 2019
| @@ -3,6 +3,12 @@ | |||
| All notable changes to this project will be documented in this file. | |||
| See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. | |||
|
|
|||
| ## Unpublished | |||
There was a problem hiding this comment.
Actually, this is automatically generated during lerna publish --conventional-commits. I appreciate the motivation, though!
|
|
||
| > Check git working tree status and collect uncommitted changes for display | ||
|
|
||
| ## Usage |
|
|
||
| const filterEmpty = (strings = []) => strings.filter(s => s.length !== 0); | ||
|
|
||
| const o = (l, r) => x => l(r(x)); |
| const transformOutput = o(filterEmpty, o(splitOnNewLine, colorizeStats)); | ||
|
|
||
| function collectUncommitted(options = {}) { | ||
| return exec("git", "status -s", options).then(transformOutput); |
There was a problem hiding this comment.
This module looks fine as-is, though I am a little concerned that the -s option of git status doesn't guarantee stability across versions (--porcelain v1 claims to do that, otherwise identical to the short format with colors always off and paths always relative).
Anyway, we can cross that bridge when we come to it, if at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to remedy (#1860) by adding a
utils/collect-uncommittedthat will resolve an array of uncommitted changes, for use in the error message inutils/check-working-tree, and anywhere else it may come in handy.I am not 100% on the formatting for the error message and would love input on the best way to display the uncommitted changes to the user.
utils/collect-uncommittedwith testscollectUncommittedin check-working-tree, when tree is dirtycollectUncommittedchanges for display to user in error message.Motivation and Context
See (#1680)
How Has This Been Tested?
Add tests in
utils/collect-uncommitted, modify existing test inutils/check-working-tree, runnpx jest,npm run integration. All tests pass in CI.Types of changes
Checklist: