Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The root package LICENSE is not included in packages having a custom publish directory #2157

Closed
patricklafrance opened this issue Jun 27, 2019 · 1 comment · May be fixed by adamlaska/scatter-js#3

Comments

@patricklafrance
Copy link

patricklafrance commented Jun 27, 2019

A new feature has been introduce to include the root package LICENSE to all the packages distributed with Lerna that doesn't already have a license. #1465

It works great for packages that doesn't specify a custom publish directory. However when a custom publish directory is specified, the published package doesn't include the LICENSE.

Expected Behavior

The root package LICENSE file should also be included in packages having a custom publish directory.

// package.json

"publishConfig": {
    "directory": "dist"
}

Current Behavior

The root package LICENSE file is only included in packages that doesn't specify a custom publish directory.

Possible Solution

Steps to Reproduce (for bugs)

  1. Create a new project with Lerna initialized
  2. Add a package to the project (make sure it's handled by Lerna)
  3. Configure a custom publish directory for the package (https://github.com/lerna/lerna/tree/master/commands/publish#per-package-configuration)
  4. Publish the package with Lerna
  5. Validate that the resulting package doesn't contains a LICENSE file
lerna.json

<!-- Please paste your `lerna.json` here -->

{
  "npmClient": "yarn",
  "useWorkspaces": true,
  "version": "independent"
}

lerna-debug.log

<!-- If you have a `lerna-debug.log` available, please paste it here -->
<!-- Otherwise, feel free to delete this <details> block -->

Context

Your Environment

Executable Version
lerna --version 3.15.0
npm --version 6.9.0
yarn --version 1.16.0
node --version 10.11
OS Version
NAME VERSION
Windows 10 1803
@patricklafrance patricklafrance changed the title The root package LICENSE is not copied to distributed packages having a custom publish directory The root package LICENSE is not included in packages having a custom publish directory Jun 27, 2019
@patricklafrance
Copy link
Author

Thank you @evocateur really appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant