feat(package): .serialize() also writes package-lock version

[mikemimik]

Description

The @core/package class has a method called .serialize() which writes the in-memory package to disk. When running lerna version the .version property of the package is updated, written, and committed (depending on flags). However, the package-lock.json file (which also has a top level version property) doesn't get updated, and is then out of sync with the package.json file.

This change updates the serialize() function to check if the package has a package-lock.json file in the directory, and if it does: read it in, update the version, then write it to disk.

Motivation and Context

Any monorepo project that has package-lock.json files in it's package folders need to run another step to get the package-lock.json files to stay in sync with the package.json files. The script usually looks something like:

lerna exec -- npm install --no-audit --no-progress
git add packages/**/package-lock.json
git commit -m "chore(package-lock): bump package lock files [skip ci]"
git push

(or some such variation of the above)

Solves: #1998
Linked: #1415

How Has This Been Tested?

Tests where added to the core/package/__tests__/core-package.test.js file.

• describe("get .lockFileLocation") was added
  • contains it("should return the package-lock location")
• describe(".serialize()") was updated
  • contains it("writes changes to package.json to disk") updated
  • contains it("writes changes to package-lock to disk") added

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[mikemimik]

It occurs to me that while this update will bump the version property in the package-lock.json file to be the same as the version property in the package.json file, the package-lock.json tree structure does not reflect the changes in package versions. This is a fundamental flaw in this feature work, and thusly should not be merged in yet. I will work to remedy this.

[evocateur]

this could be npm-shrinkwrap.json, or yarn.lock, or, or, or...

[evocateur]

I don't think we need p-waterfall just to chain promises. This check should be done way earlier, too.

[evocateur]

Unclear why this is necessary, as it is already ignored.

[evocateur]

This isn't the appropriate place for lockfile maintenance. It's a function of the version command, not integral to the nature of a Package.

[evocateur]

v3.18.2