Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lerna: Semver convention was broken #2177

Closed
kevinwolfcr opened this issue Jul 11, 2019 · 1 comment · May be fixed by adamlaska/scatter-js#3
Closed

Lerna: Semver convention was broken #2177

kevinwolfcr opened this issue Jul 11, 2019 · 1 comment · May be fixed by adamlaska/scatter-js#3

Comments

@kevinwolfcr
Copy link

Hello guys! I have been using lerna to release my monorepos for a while, and it have been a good fit all the time.

But...

Yesterday I was setting up a new monorepo, and seeing at the logs generated by mi CI, I've saw that the release was skipped.

By taking a look at the latest release, I've saw that githubRelease was deprecated in favour of createRelease.

I think this broke the semver specification, which says that *every breaking change should be a major release".

Any thoughts?

@evocateur
Copy link
Member

It's still functional, just deprecated. The issue you're experiencing is that you're using the command.publish namespace to configure githubRelease, and we missed that during the refactoring. We did not intentionally violate semver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants