Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(add): Add --peer option to save target in peerDependencies #2334

Merged
merged 1 commit into from Nov 20, 2019

Conversation

icrosil
Copy link
Contributor

@icrosil icrosil commented Nov 8, 2019

Description

Added peer option in add command.
Pretty similar to devDependencies.

Motivation and Context

A lot of packages need to define peerDependencies as well as other options. Currently, only manual option is available.
#1947

How Has This Been Tested?

  • Link lerna to local machine
  • Run add command with peer flag
  • check peerDependencies in your package

Mac OS 10.15 Catalina, Node 12.

Added one more expect to check if peerDependency added.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@icrosil icrosil changed the title feat: Added peer as option in add command feat(add): Added peer as option in add command Nov 8, 2019
Copy link
Member

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant!

@evocateur evocateur changed the title feat(add): Added peer as option in add command feat(add): Add --peer option to save target in peerDependencies Nov 20, 2019
@evocateur evocateur merged commit e12bf6a into lerna:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants