feat(publish): Add --legacy-auth flag
#2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agirton
commented
Nov 15, 2019
evocateur
suggested changes
Nov 20, 2019
commands/publish/command.js
Outdated
| @@ -35,6 +35,11 @@ exports.builder = yargs => { | |||
| type: "string", | |||
| requiresArg: true, | |||
| }, | |||
| "legacy-auth": { | |||
| describe: "Legacy Base64 Encoded username and password.", | |||
| alias: "_auth", | |||
There was a problem hiding this comment.
--_auth is an extremely odd option name. Please don't add this alias.
There was a problem hiding this comment.
This is actually the same as the npm _auth flag. So using that as a signal that it's a pass through. But I can remove it and then put this in the description/docs.
We will still use _auth internally because that is what NPM expects.
|
@evocateur thank you so much for the review! Conflicts still need to be fixed, but let me know if everything else looks ok to you. This will be huge for us if merged in 😄 |
evocateur
approved these changes
Dec 15, 2019
evocateur
changed the title
--legacy-auth flag
|
Thanks for your patience! |
|
Hey @evocateur thank you for merging this in! Any idea when you would like to publish the next release? Did you want to wait till after the holidays? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new(ish)
_auth/legacy-authflag to thepublishcommand that allows users of lerna work with NPM registries that still use the "legacy" authorization type for publishing their packages. This_authflag is already supported by npm, so the change is small.Motivation and Context
There are some registries that still use the legacy NPM
_authflag for authorization. In the NPM docs they refer this auth type as "legacy". Lerna today does not support this flag, but it is supported by the npmpublishcommand. Which means that if we need to pass in this authorization we have to opt out of all the goodnesslerna publishcommand provides and uselerna execto run thenpm publish --_auth=Base64Strcommand.How Has This Been Tested?
Types of changes
Checklist: