Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bootstrap install to use quotes around versions #235

Merged
merged 2 commits into from Jun 20, 2016

Conversation

jamiebuilds
Copy link
Contributor

@jamiebuilds jamiebuilds commented Jun 20, 2016

Fixes #234

@@ -109,7 +109,7 @@ export default class BootstrapCommand extends Command {
return !this.hasDependencyInstalled(pkg, dependency);
})
.map(dependency => {
return dependency + "@" + allDependencies[dependency];
return dependency + "@\"" + allDependencies[dependency] + "\"";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is getting into the range where a template string might be more readable:

return `${dependency}@"${allDependencies[dependency]}"`;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gigabo i concur

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could leave a comment of an example package version of why it needs the quotes

@jamiebuilds jamiebuilds changed the title Fix bootstrap install to use quotes around versions (Fixes #234) Fix bootstrap install to use quotes around versions Jun 20, 2016
@jamiebuilds jamiebuilds merged commit c0f1e8d into master Jun 20, 2016
@jamiebuilds jamiebuilds deleted the fix-installed-versions branch June 20, 2016 21:45
jamiebuilds added a commit that referenced this pull request Jun 21, 2016
LoicMahieu added a commit to LoicMahieu/lerna that referenced this pull request Jun 28, 2016
* feature/pkg-main:
  Bootstrap: copy `main` property from package.json
  2.0.0-beta.23
  fix execSync use
  Add `onlyExplicitUpdates` flag so that only packages that have changed have version bumps rather than all packages that depend on the updated packages (lerna#241)
  Re-introduce node 0.10 support (lerna#248)
  2.0.0-beta.22
  Consistent naming in README `import` section (lerna#243) [skip ci]
  Lerna import (lerna#173)
  Revert "Use sync-exec for node 0.10" (lerna#242)
  Revert "Fix bootstrap install to use quotes around versions (lerna#235)"
  2.0.0-beta.21
  Fix bootstrap install to use quotes around versions (lerna#235)
  typo [skip ci]

# Conflicts:
#	src/commands/BootstrapCommand.js
@lock
Copy link

lock bot commented Dec 28, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants