Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): Support --tag-version-prefix in --canary mode #2435

Merged
merged 2 commits into from May 23, 2020
Merged

fix(publish): Support --tag-version-prefix in --canary mode #2435

merged 2 commits into from May 23, 2020

Conversation

Fl0pZz
Copy link
Contributor

@Fl0pZz Fl0pZz commented Feb 2, 2020

Motivation and Context

Fix #2433

How Has This Been Tested?

Run integration and unit tests and link to my project, where was problem with publish.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Fl0pZz Fl0pZz requested a review from evocateur February 2, 2020 14:56
Copy link
Member

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, thanks for your patience!

@evocateur evocateur changed the title fix (publish): canaries mode support --tag-version-prefix fix(publish): Support --tag-version-prefix in --canary mode May 23, 2020
@evocateur evocateur merged commit 611c38e into lerna:master May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canary mode bug with custom tag prefix
2 participants