Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): upgrade octokit/enterprise-rest to v6 #2464

Merged
merged 1 commit into from May 23, 2020

Conversation

mlavina
Copy link
Contributor

@mlavina mlavina commented Feb 24, 2020

Description

This change upgrades the octokit/enterprise-rest plugin to v6

Motivation and Context

Currently, Lerna is using v3 of the plugin and that doesn't support Github enterprise 2.18

How Has This Been Tested?

Updated test to use GHE_VERSION 2.18

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@uncleramsay
Copy link

Is there any update on this? I would also like to use lerna publish with GitHub Enterprise 2.18

@mlavina
Copy link
Contributor Author

mlavina commented Mar 24, 2020

@evocateur checking in if you had a chance to look at this.

Thanks,
Michael

@uncleramsay
Copy link

@evocateur any update here? Thank you

@mlavina
Copy link
Contributor Author

mlavina commented Apr 30, 2020

Hey @evocateur just checking in again if there is any update on this.

My team's current work around is we need to add resolutions in every project that wants this, which works, but it just adds overhead that can be forgotten and resolutions can add instability.

-Michael

@mlavina
Copy link
Contributor Author

mlavina commented May 21, 2020

Hey @evocateur just checking in again if there are updates on this.

Copy link
Member

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience!

@evocateur evocateur merged commit b44ea75 into lerna:master May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants