Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version): --atomic fallback when GIT_REDIRECT_STDERR is enabled #2467

Merged

Conversation

paulocmoreno
Copy link
Contributor

@paulocmoreno paulocmoreno commented Feb 26, 2020

Description

Lerna --atomic fallback now checks if the environment variable GIT_REDIRECT_STDERR has been configured. This configuration is necessary to handle a questionable Windows Server 2019 behavior. More details here

Motivation and Context

This change is necessary to support Azure Pipelines on Windows Server 2019.

How Has This Been Tested?

  • Unit testing.
  • Using a modified lerna version in an Azure Pipeline.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@paulocmoreno paulocmoreno changed the title fix(version): --atomic fallback when GIT_REDIRECT_STDERR is enabled fix(version): --atomic fallback when GIT_REDIRECT_STDERR is enabled Feb 26, 2020
@MrStLouis
Copy link

adding this here as this is an open related pull request instead of #2393, could we add better handling of when it succeeds? New to all of this, but I assumed some part of it had failed, but git status was clean.

lerna info git Pushing tags...
lerna WARN gitPush --atomic failed, attempting non-atomic push
lerna WARN gitPush fatal: the receiving end does not support --atomic push
lerna WARN gitPush fatal: the remote end hung up unexpectedly
lerna WARN gitPush error: failed to push some refs to 'https://org@dev.azure.com/org/project/_git/myRepository'
lerna WARN gitPush
lerna success version finished
PS C:\myRepository> git status
On branch feature/consolidate
Your branch is up to date with 'origin/feature/ci'.

nothing to commit, working tree clean

I guess I was looking for a lerna success gitPush "something?" after all of the WARNs.

@paulocmoreno paulocmoreno force-pushed the fix-atomic-git-redirect-std-err branch from ab46fdb to 1e62c4a Compare March 10, 2020 15:42
@paulocmoreno
Copy link
Contributor Author

paulocmoreno commented Mar 10, 2020

@MrStLouis, I changed the order of the messages. The message "--atomic failed, attempting non-atomic" will be write after the warnings with a INFO category. Is it better now?

Copy link
Member

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants