Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(conventional-commits): Support modern config builder functions #2546

Merged
merged 1 commit into from May 24, 2020
Merged

fix(conventional-commits): Support modern config builder functions #2546

merged 1 commit into from May 24, 2020

Conversation

MunifTanjim
Copy link
Contributor

@MunifTanjim MunifTanjim commented Apr 16, 2020 •
edited

Fixes #2138

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MunifTanjim MunifTanjim force-pushed the fix/2138 branch 2 times, most recently from c6cc089 to 1ea7403 Compare April 17, 2020 00:08
@MunifTanjim MunifTanjim changed the title fix(conventional-commits): use conventional-changelog-preset-loader fix(conventional-commits): support conventional-changelog-conventionalcommits Apr 17, 2020
evocateur
evocateur approved these changes May 24, 2020
View reviewed changes
Copy link
Member

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience!

core/conventional-commits/__tests__/conventional-commits.test.js Show resolved Hide resolved
@evocateur evocateur changed the title fix(conventional-commits): support conventional-changelog-conventionalcommits fix(conventional-commits): Support modern config builder functions May 24, 2020
@evocateur evocateur merged commit 7ffb297 into lerna:master May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evocateur evocateur evocateur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@lerna/conventional-commits unable to use conventional-changelog-conventionalcommits
2 participants
@MunifTanjim @evocateur