New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(import): Better handling of "Patch is empty" #2588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the import command is a list of hacks to begin with, is there any other way we can know the "emptiness" of the commit? I'm reticent to add a list of hard-coded localized strings, but I understand hard-coded English isn't a better solution.
LANG=ru_RU.UTF-8
LANG
other than en_US.UTF-8
LANG
other than en_US.UTF-8
@evocateur Hi! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Using `git diff COMMIT^!` to check if patch is empty instead of English-only hard-coded string.
Description
Removed check for hard-coded "Patch is empty." git message in favor of
git diff COMMIT^!
check.Fixes #2351 , fixes #2587
Motivation and Context
Command
lerna import --flatten <path/to/repo>
fails ifLANG
environment variable set toru_RU.UTF-8
(default value on macOS in Russia).Example output:
How Has This Been Tested?
Updated command's code and successfully imported repo with multiple locales including:
en_US.UTF-8
,ru_RU.UTF-8
,en_IN.utf8
,es_ES.UTF-8
andde_CH.ISO8859-1
.Types of changes
Checklist: