-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installing lerna still shows one deprecated warnings for used module functionality #3605
Comments
Experiencing the same issue over here and it's breaking our pipelines.
Looks like it could be caused by the latest update to @nrwl/tao |
This is happening on node v16.10.0 and not on v16.19.1
|
@mleenaerts as mentioned in #3559. The issue was only partially fixed. Some package requiring this deprecated dep is still not updated. So the issue should not have been closed. I will have another look into this. Maybe we could now update the evil package version. And yes i was not explicit enough on this |
@amorscher I guess I trusted the comments and didn't check myself as well. But anyways, your support and feedback was and is much appreciated. |
I believe |
Actually sadly I think it will still get dragged in by the latest
|
@lukekarrys sorry for the direct ping but do you know if there are any near term plans to update this usage so that the deprecation warning can be avoided? |
I think it is due to node-gyp. Which currently has a pull request open (nodejs/node-gyp#2796) to move to a newer version of make-fetch-happen. But this is somehow blocked... |
I'm the author of a PR to It would be a major bump for |
@markmxr node v16.19.1 lerna 6.6.1 still has the issue |
What's the status on this, now that nodejs/node-gyp#2770 is merged? |
I still see the warning when installing lerna v8.0.0, if that's what you mean. |
All the relevant npm internal deps have now received the relevant updates thanks to Luke, so I've merged #3919 which addresses the issue on the lerna side (verified locally). Will cut a release later today which contains the update |
When installing lerna via npm install still one warning is shown about the usage of deprecated functionalities of used modules.
This behaviour is still present in release 6.6.0 although a previous PR should have corrected it, but it seems only one of the two reported issues is revolved. (See #3550 and #3559)
Still present is the following warning:
npm WARN deprecated @npmcli/move-file@2.0.1: This functionality has been moved to @npmcli/fs
Expected Behaviour
I would prefer the replacement of the deprecated code to avoid potential future issues as soon as possible.
Steps to Reproduce
Create an empty folder and create a package.json file in that folder with the following content.
Run npm install and notice the warning message regarding deprecated functionality.
Failure Logs / Configuration
npm WARN deprecated @npmcli/move-file@2.0.1: This functionality has been moved to @npmcli/fs
The text was updated successfully, but these errors were encountered: