Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing lerna still shows one deprecated warnings for used module functionality #3605

Closed
mleenaerts opened this issue Mar 23, 2023 · 13 comments · Fixed by #3624 or #3919
Closed

Installing lerna still shows one deprecated warnings for used module functionality #3605

mleenaerts opened this issue Mar 23, 2023 · 13 comments · Fixed by #3624 or #3919

Comments

@mleenaerts
Copy link

mleenaerts commented Mar 23, 2023

When installing lerna via npm install still one warning is shown about the usage of deprecated functionalities of used modules.
This behaviour is still present in release 6.6.0 although a previous PR should have corrected it, but it seems only one of the two reported issues is revolved. (See #3550 and #3559)

Still present is the following warning:
npm WARN deprecated @npmcli/move-file@2.0.1: This functionality has been moved to @npmcli/fs

Expected Behaviour
I would prefer the replacement of the deprecated code to avoid potential future issues as soon as possible.

Steps to Reproduce
Create an empty folder and create a package.json file in that folder with the following content.

{
  "name": "test-app",
  "devDependencies": {
    "lerna": "6.6.0"
  }
}

Run npm install and notice the warning message regarding deprecated functionality.

Failure Logs / Configuration
npm WARN deprecated @npmcli/move-file@2.0.1: This functionality has been moved to @npmcli/fs

@markmxr
Copy link

markmxr commented Mar 23, 2023

Experiencing the same issue over here and it's breaking our pipelines.

Run npm install -g lerna@5.6.1
npm WARN deprecated readdir-scoped-modules@1.1.0: This functionality has been moved to @npmcli/fs
npm WARN deprecated @npmcli/move-file@2.0.1: This functionality has been moved to @npmcli/fs
npm ERR! code ENOENT
npm ERR! syscall chmod
npm ERR! path /opt/hostedtoolcache/node/16.10.0/x6[4](https://github.com/ManageXR/mighty-api/pull/106/checks#step:4:5)/lib/node_modules/lerna/node_modules/@nrwl/tao/index
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, chmod '/opt/hostedtoolcache/node/1[6](https://github.com/ManageXR/mighty-api/pull/106/checks#step:4:7).[10](https://github.com/ManageXR/mighty-api/pull/106/checks#step:4:11).0/x64/lib/node_modules/lerna/node_modules/@nrwl/tao/index'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

Looks like it could be caused by the latest update to @nrwl/tao

@markmxr
Copy link

markmxr commented Mar 23, 2023

This is happening on node v16.10.0 and not on v16.19.1

Experiencing the same issue over here and it's breaking our pipelines.

Run npm install -g lerna@5.6.1
npm WARN deprecated readdir-scoped-modules@1.1.0: This functionality has been moved to @npmcli/fs
npm WARN deprecated @npmcli/move-file@2.0.1: This functionality has been moved to @npmcli/fs
npm ERR! code ENOENT
npm ERR! syscall chmod
npm ERR! path /opt/hostedtoolcache/node/16.10.0/x6[4](https://github.com/ManageXR/mighty-api/pull/106/checks#step:4:5)/lib/node_modules/lerna/node_modules/@nrwl/tao/index
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, chmod '/opt/hostedtoolcache/node/1[6](https://github.com/ManageXR/mighty-api/pull/106/checks#step:4:7).[10](https://github.com/ManageXR/mighty-api/pull/106/checks#step:4:11).0/x64/lib/node_modules/lerna/node_modules/@nrwl/tao/index'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent

Looks like it could be caused by the latest update to @nrwl/tao

@amorscher
Copy link
Contributor

amorscher commented Mar 24, 2023

@mleenaerts as mentioned in #3559. The issue was only partially fixed. Some package requiring this deprecated dep is still not updated. So the issue should not have been closed. I will have another look into this. Maybe we could now update the evil package version.

And yes i was not explicit enough on this

@mleenaerts
Copy link
Author

@amorscher I guess I trusted the comments and didn't check myself as well. But anyways, your support and feedback was and is much appreciated.

@JamesHenry
Copy link
Member

I believe pacote was responsible for this and I have merged in a change bumping it to the latest version so this should be fixed in the next release

@JamesHenry JamesHenry reopened this Mar 29, 2023
@JamesHenry
Copy link
Member

JamesHenry commented Mar 29, 2023

Actually sadly I think it will still get dragged in by the latest @npmcli/run-script:

❯ npm ls @npmcli/move-file
lerna-monorepo@
└─┬ @npmcli/run-script@6.0.0
  └─┬ node-gyp@9.0.0
    └─┬ make-fetch-happen@10.2.0
      └─┬ cacache@16.1.1
        └── @npmcli/move-file@2.0.0

@JamesHenry
Copy link
Member

@lukekarrys sorry for the direct ping but do you know if there are any near term plans to update this usage so that the deprecation warning can be avoided?

@amorscher
Copy link
Contributor

amorscher commented Mar 29, 2023

I think it is due to node-gyp. Which currently has a pull request open (nodejs/node-gyp#2796) to move to a newer version of make-fetch-happen. But this is somehow blocked...

@lukekarrys
Copy link

I'm the author of a PR to node-gyp that would alleviate any deprecation warnings that are caused by it: nodejs/node-gyp#2770

It would be a major bump for node-gyp but would then be released in a patch of @npmcli/run-script. That PR is currently awaiting review so it has fallen off in priority a bit as I wait for that.

@banyaner
Copy link

@markmxr node v16.19.1 lerna 6.6.1 still has the issue

@Anutrix
Copy link

Anutrix commented Dec 15, 2023

What's the status on this, now that nodejs/node-gyp#2770 is merged?

@mleenaerts
Copy link
Author

I still see the warning when installing lerna v8.0.0, if that's what you mean.
npm WARN deprecated @npmcli/move-file@2.0.1: This functionality has been moved to @npmcli/fs

@JamesHenry
Copy link
Member

All the relevant npm internal deps have now received the relevant updates thanks to Luke, so I've merged #3919 which addresses the issue on the lerna side (verified locally).

Will cut a release later today which contains the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants