Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update to rimraf v4, remove path-exists #3616

Merged
merged 4 commits into from Mar 24, 2023
Merged

Conversation

JamesHenry
Copy link
Member

@JamesHenry JamesHenry commented Mar 24, 2023

Refactors rimraf usage to no longer attempt to resolve the bin and invoke it via a child process because the bin is not resolvable in modern Node thanks to package exports. Hopefully using the primary node API should be what we want anyway.

Also removes the unnecessary path-exists dependency

@JamesHenry JamesHenry changed the title chore: update to rimraf v4 fix(deps): update to rimraf v4, remove path-exists Mar 24, 2023
@tada5hi
Copy link
Contributor

tada5hi commented Mar 24, 2023

@JamesHenry i think that, as you have already noted, the better way is to use the api directly instead of the cli variant 👍 .

@JamesHenry JamesHenry marked this pull request as ready for review March 24, 2023 18:04
@JamesHenry JamesHenry merged commit 2f2ee2a into main Mar 24, 2023
13 checks passed
@JamesHenry JamesHenry deleted the rimraf-4 branch March 24, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants