fix(#3294): use loadFileSync when loading plugins with syncImport: true #3506
+40
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added some tests (including a regression test for @matthew-dean It would be very appreciated if you can take a look at this when you have time :) |
|
Thanks! |
|
Hi @matthew-dean, could you please release a new version when you have time? (I'm actually waiting for this feature to be shipped so that I can use Less plugins in a project based on vite, which only supports sync mode ATM). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the only way to compile Less code synchronously is by setting
syncImport: true. But as described in #3294, it cannot work when it involves plugins. In factloadPlugindidn't have a sync version. This PR added aloadPluginSyncmethod to fix this problem.PS. I didn't quite understand how tests work so tests are not included. Any help would be appreciated.Please note: compiled files are not included in this PR.