Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions #367

Open
acudroit opened this issue Jun 12, 2022 · 5 comments
Open

Suggestions #367

acudroit opened this issue Jun 12, 2022 · 5 comments

Comments

@acudroit
Copy link

  • allow users to change their text color
  • allow users to change color of quote line
@acudroit
Copy link
Author

Actually, when you say we can control the appearance of the site by CSS what do you mean exactly? Because I'm trying to change the background color and text but nothing is happening

@acudroit
Copy link
Author

acudroit commented Jun 12, 2022

Also the formatting doesn't look that well from mobile view, such as the quote format it's not appearing at all when I read my blog from mobile view or the h2 format

@acudroit
Copy link
Author

Nevermind my browser wasn't updated haha.. haha..

@acudroit
Copy link
Author

acudroit commented Jun 12, 2022

But about the CSS feature, what am I allowed to implement exactly and in which format should I implement it? Using the standard CSS method of perhaps

body {
}

or is it something more less formal like

background-color: xyz;

without any brackets?

@abhisaha1
Copy link
Member

abhisaha1 commented Jun 16, 2022

The CSS should be written in the normal way. Like this:

body {
   background: #eee;
   font-size: 20px;
}

However this feature has been deactivated. The problem is that reader has the choice to change the theme to light or dark. So any color you use to decorate text, might have a problem when the theme is changed.

I had already added a class to handle css for both. eg.

   body {
      color: #000; /* for light theme */
   }
   .dark body {
        color: #fff; /* for dark theme */
   }

This needs to be server rendered so that there is no flickering. I haven't done this yet but will be ready soon.. in a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants