Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Document on dynamicRefreshSources #2139

Closed
DanielYWoo opened this issue Jul 5, 2022 · 1 comment
Closed

Improve Document on dynamicRefreshSources #2139

DanielYWoo opened this issue Jul 5, 2022 · 1 comment
Labels
type: documentation A documentation update
Milestone

Comments

@DanielYWoo
Copy link

Feature Request

The doc says

         * Discover cluster nodes from topology and use the discovered nodes as source for the cluster topology. Using dynamic
         * refresh will query all discovered nodes for the cluster topology and calculate the number of clients for each node.If
         * set to {@code false}, only the initial seed nodes will be used as sources for topology discovery and the number of
         * clients will be obtained only for the initial seed nodes. This can be useful when using Redis Cluster with many
         * nodes. Defaults to {@code true}. See {@link ClusterTopologyRefreshOptions#DEFAULT_DYNAMIC_REFRESH_SOURCES}.

I believe we use "CLUSTER INFO" to build the client view of the cluster topology (nodes and slot partitions), if we only query seeds, or even a single seed, we still have the whole cluster view, that's efficient and no need to query all nodes. The only reason we query all nodes is to get the number of connections per node by "INFO" command, right? But, I don't get why we need the number of clients, is it for least-connection strategy with pub/sub? Can we specify why and the usage scope of this parameter?

Is your feature request related to a problem? Please describe

No

Describe the solution you'd like

N/A

Describe alternatives you've considered

N/A

Teachability, Documentation, Adoption, Migration Strategy

N/A

@mp911de
Copy link
Collaborator

mp911de commented Nov 22, 2022

Each cluster node may have a different topology view, especially if the configuration is inconsistent. We use client count and response latency later on for ReadFrom.LOWEST_LATENCY.

@mp911de mp911de added the type: documentation A documentation update label Nov 22, 2022
@mp911de mp911de added this to the 6.2.2.RELEASE milestone Nov 22, 2022
@mp911de mp911de closed this as completed Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

2 participants