Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdi-react-native #71

Open
d4rky-pl opened this issue Jan 13, 2020 · 6 comments
Open

mdi-react-native #71

d4rky-pl opened this issue Jan 13, 2020 · 6 comments

Comments

@d4rky-pl
Copy link

Hey! I love your library!

It would be amazing if other than mdi-react and mdi-preact there was a third option, mdi-react-native. The differences would be tiny:

  • do not apply default className
  • replace svg and path with import Svg, { Path } from 'react-native-svg'
  • I'm not 100% sure right now but I think fill needs to be applied on Path instead of Svg

I'd love to send a PR but I'm not a TypeScript person so I gave up after trying to fix the typings (sorry!)

Would you be interested in adding this and releasing it as your own library or would you rather not maintain any extra baggage and I should just fork? :)

@levrik
Copy link
Owner

levrik commented Jan 13, 2020

Hey there. Just leave the TypeScript typings out and open a PR. I'll add them to your PR.

@levrik
Copy link
Owner

levrik commented Feb 5, 2020

Any updates on this from your side?

@d4rky-pl
Copy link
Author

d4rky-pl commented Feb 5, 2020

Sorry! We ultimately went with a different approach and I totally forgot about this 🤦‍♂
I'll take a look later today and will send a PR 👍

@d4rky-pl
Copy link
Author

Just to let you know, I remember about this issue but couldn't find time because of traveling 😅 Please keep it open!

@jjarrett21
Copy link

Any updates on this?

@d4rky-pl
Copy link
Author

To be honest due to the global pandemic and everything related to it, I completely forgot about this issue and the code I already had prepared.

I sent a PR #79, it still requires TS fixes though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants