Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSONWebToken Token naming #1122

Open
Ahummeling opened this issue Feb 22, 2023 · 2 comments
Open

JSONWebToken Token naming #1122

Ahummeling opened this issue Feb 22, 2023 · 2 comments

Comments

@Ahummeling
Copy link

First of all, thank you very much for this awesome bundle!

I came across a very straight forward exception message, and got a little annoyed with the wording:

{
  "code": 401,
  "message": "JWT Token not found"
}

The T in JWT stands for Token, so this reads out to "JSON Web Token Token not found". In my native language, this is considered a grammatical error, I am not sure if this is the case in english. More importantly, I am even less sure about whether this naming might've been intentional.

I wanted to submit a PR that "fixes" the occurrences of JWT Token by renaming them to JWT where it makes sense to do so. But I wanted to check first that such a PR would be appreciated in the first place.

Again thanks for the awesome bundle, I'm hoping to make it ever so slightly better.

@Bryce-Colton
Copy link

In my view, the acronym 'JWT' works well – a quick way to convey or refer to what you're talking about. In France, everyone says 'JWT token' in French conversations.

If you wish to make improvements, kindly provide a configuration option for the default error message. That way, everyone will be satisfied :)

@Bryce-Colton
Copy link

Same open issue here : #983 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants