Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented assumption #1141

Open
boite opened this issue May 11, 2023 · 0 comments
Open

Undocumented assumption #1141

boite opened this issue May 11, 2023 · 0 comments

Comments

@boite
Copy link

boite commented May 11, 2023

Forgive me if this is documented already.

There is an assumption about how this bundle will be used which isn't immediately apparent. Specifically it is assumed that the JWTs which this bundle will authenticate are signed using the algo named in encoder.signature_algorithm. It's not immediately apparent that additonal_public_keys cannot be populated with the pubkeys of other JWT issuers who may sign using a variety of algos.

For example, if one doesn't change encoder.signature_algorithm from the default RS256, then one might be surprised to find the bundle treats as invalid JWTs signed using RS512, even when additonal_public_keys contains the corresponding pubkey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant