Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What are the advantages over reywood:publish-composite package #13

Open
vladejs opened this issue Aug 8, 2017 · 5 comments
Open

What are the advantages over reywood:publish-composite package #13

vladejs opened this issue Aug 8, 2017 · 5 comments

Comments

@vladejs
Copy link

vladejs commented Aug 8, 2017

I wonder what are the advantages regarding performance and flexibility.

I'am considering one of these to start a new project.

@vladejs vladejs changed the title What are the advanteges over reywood:publish-composite package What are the advantages over reywood:publish-composite package Aug 8, 2017
@lfades
Copy link
Owner

lfades commented Aug 8, 2017

when I write this package I saw publish-composite first and I didn't like it, because it's using the observers in a bad way. Most of the times you only need to use observeChanges as Meteor does by default (they always use observe), I explain that here and you can see their implementation here.

They also have some warnings but with publish-relations as long as you follow the recommendations you should never have performance problems

@lfades
Copy link
Owner

lfades commented Aug 8, 2017

publish-relations also allow you to have non reactive cursors and joins, very useful when you're sure you don't need reactive data in some places :D (and very performant friendly)

@vladejs
Copy link
Author

vladejs commented Aug 8, 2017

They also have some warnings but with this package as long as you follow the recommendations you should never have performance problems

You mean theirs or yours?

Talking about recommendations, I read the Performance section and saw that inmediatelly deprecates your first usage example of the package with joins. Why not teach to use joins from the start?

Could you document a complete example on using joins without nested this.cursor? For example, an Artist has multiple Images, and every image has artistId and Comments has imageId.

@lfades
Copy link
Owner

lfades commented Aug 8, 2017

I fixed the typo, thanks.

I have a note under the example that points to the recommendations, there is the same example but with a join.

When I have free time I could check the README again but I'm a little busy at the moment, also my english was really bad when I created this package in 2015 (I was 17)

@vladejs
Copy link
Author

vladejs commented Aug 8, 2017

Thanks for your time @goluis , I speak spanish as well so if you are willing to create a README_ES and explain it better I definitely will read it 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants