Option to use getDataFromTree also on client?

[borekb]

Currently, getDataFromTree works only during SSR due to this condition:

next-with-apollo/src/withApollo.tsx

Line 69 in e0ddc5a

if (typeof window === 'undefined') {

On the client, you'll see "Loading..." due to this, which is not bad but an alternative UX that we actually prefer is to wait for all data to load and only then change the route, sort of like with turbolinks.

To achieve that, we maintain a fork of with-apollo but that is own drawbacks, obviously. Would this project consider accepting a PR that would make this configurable, like this?

export default withApollo(Index, { getDataFromTree, useGetDataFromTreeAlsoOnClient: true });

(Naming it will be challenging 😄.)

[Faisal-Manzer]

Hey, can I get access to the fork repo. This issue is just annnoying.

[zenflow]

Before this can work this Next.js issue will need to be fixed: vercel/next.js#10126 / vercel/next.js#9336

Maybe clientPrepass: true? It should be something short anyways 😄

[zenflow]

clientSidePreload: true