Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there any plans to upgrade this library to apollo/client 3.x ? #147

Open
2 tasks done
awkward-minion opened this issue Jul 30, 2020 · 6 comments
Open
2 tasks done
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@awkward-minion
Copy link

  • Can we have hook in place of HOC (withApollo) ?
  • Are there any plans to upgrade this library to apollo/client 3.x?
@petrbela
Copy link

petrbela commented Aug 6, 2020

Note that next.js has an example project set up with the latest Apollo Client so you might not need this library to make it work.

@lfades lfades added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 7, 2020
@lfades
Copy link
Owner

lfades commented Aug 7, 2020

There's a PR open for it but it's outdated: #132 (comment)

Updating the package to support Apollo 3 is not currently one of my priorities, I'm part of the Next.js team and my focus is there, I managed to update the Apollo examples and I recommend you to take a look there instead 👍

@ilackovic
Copy link

ilackovic commented Sep 23, 2020

@lfades, since you are a NextJS team member I'll just write my reasoning why this package should still be maintained and also be a part of the Next and not a helper package.

Reason for that is simple, you have a user base using NextJS and whole applications written before the implementations of SSG and SSR that NextJS team is pushing devs to use.

You also as of today, have around 24 000 downloads weekly for this package.

I have a large application written with getInitialProps for SSR / SEO and my team does not have the resources or time needed to rewrite the whole application to use getStaticProps or getServerSide props just because Next team decided to deprecate getInitialProps (in a way, since it's basically nowhere to be found on the official Next examples and where it is mentioned in the documentation - it's there only to say that you should use the newer implementation).
And the whole withApollo implementation is dependent on this package.

You are leaving the whole chunk of users hanging and unable to upgrade to newer versions of Apollo with this implementation.

So please, update the package to a version where we can use Apollo Client v3.

@chemicalkosek
Copy link

chemicalkosek commented Sep 23, 2020

I'm using this package with Apollo Client v3 with no problems (with getInitialProps). What doesn't work for you?

@lfades
Copy link
Owner

lfades commented Sep 23, 2020

@ilackovic I understand that and some time ago I decided to not include Apollo dependencies due to it changing too often in the beta versions. Right now the package only has Apollo in devDependencies for testing and types. But you're free to choose the Apollo version

@gvidon
Copy link

gvidon commented Dec 27, 2020

Seems like the most incompatibility arises from TypeScript typings. Apollo Client v2 types are not compatible with Apollo Client v3 types. A brutal // @ts-ignore obviously fixes the issue, but a more delicate patch would be nicer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants