Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PaperError not functioning correctly #50

Closed
liamross opened this issue Jun 20, 2018 · 3 comments
Closed

PaperError not functioning correctly #50

liamross opened this issue Jun 20, 2018 · 3 comments
Assignees
@liamross
Labels
🐛 bug Something isn't working 🚨 critical Top priority to fix or implement
Projects
Major Release

Comments

@liamross
Copy link
Owner

Describe the bug

  1. Babel < 7 doesn't allow you to extend Errors
  2. PaperError needs to extend Errors

To Reproduce

  1. Generate a PaperError, and notice it's not fully 'fleshed out'

Expected behavior

  1. PaperError should be instanceof PaperError and should override toString method

Additional context

Check status on Parcel --> Babel 7 here: parcel-bundler/parcel#868
@liamross liamross added 🐛 bug Something isn't working 🏭 release: major labels Jun 20, 2018
@liamross liamross self-assigned this Jun 20, 2018
@liamross liamross added this to To do in Major Release via automation Jun 20, 2018
@liamross liamross added the 🛑 blocked This bug or feature is blocked label Jun 20, 2018
@liamross
Copy link
Owner Author

May need to move away from Parcel sadly... time for Webpack 4 w/ Babel 7?

Issues:

  1. May need to move script.ts in demo over to javascript, as some weird interactions with monorepo organization of tsconfig files (inheriting from base config and in each branch of projects folder)
  2. Babel 7 is still in beta so everything could be iffy

@liamross
Copy link
Owner Author

liamross commented Sep 1, 2018

This does not need Babel 7, as tsc is compiling the packages (it has nothing to do with Parcel).

Follow the discussion here to update functionality and properly extend Error:
https://stackoverflow.com/questions/41102060/typescript-extending-error-class

@liamross liamross added 🚨 critical Top priority to fix or implement and removed 🛑 blocked This bug or feature is blocked labels Sep 1, 2018
@liamross liamross changed the title PaperError not functioning correctly, needs Babel 7 PaperError not functioning correctly Sep 1, 2018
@liamross
Copy link
Owner Author

Working with new typescript updates

Major Release automation moved this from To do to Done Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liamross liamross

Labels
🐛 bug Something isn't working 🚨 critical Top priority to fix or implement
Projects
Major Release
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@liamross