7z sfx overaly detection #2088
Open
7z sfx overaly detection #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (__archive_read_seek(a, e_shoff, SEEK_SET) < 0) { | ||
| break; | ||
| } | ||
| h = __archive_read_ahead(a, e_shnum * e_shentsize, NULL); |
Check failure
Code scanning / CodeQL
Multiplication result converted to larger type High
| if (__archive_read_seek(a, e_shoff, SEEK_SET) < 0) { | ||
| break; | ||
| } | ||
| h = __archive_read_ahead(a, e_shnum * e_shentsize, NULL); |
Check failure
Code scanning / CodeQL
Multiplication result converted to larger type High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To detect 7z SFX files, libarchive currently searches for the 7z header in a hard-coded addr range of the PE/ELF file
(specified via macros SFX_MIN_ADDR and SFX_MAX_ADDR). This causes it to miss SFX files that may stray outside these values (libarchive fails to extract 7z SFX ELF files created by recent versions of 7z tool because of this issue). This patch fixes the issue by finding a more robust starting point for the 7z header search: overlay in PE or the .data section in ELF. This patch also adds 3 new test cases for 7z SFX to libarchive.
Fixes #2075