7z: skip unsupported headers #2086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehrabiworkmail
changed the title
|
Without applying the fix, libarchive fails 2 of the 3 new test cases (the vanilla 7z SFX ELF and the modified 7z SFX PE). |
mehrabiworkmail
commented
Mar 8, 2024
| { | ||
| const void *h; | ||
| const char *p, *q; | ||
| size_t skip, offset; | ||
| ssize_t bytes, window; | ||
|
|
||
| /* |
There was a problem hiding this comment.
This had to be modified because find_pe_overlay and find_elf_data_sec may read or seek the archive, hence bytes_avail is no longer reliable.
mehrabiworkmail
changed the title
mehrabiworkmail
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7z doesn't support kAdditionalStreamInfo which causes it to not extract anything from files that contain this header. This patch enables libarchive to skip unsupported headers and still extract data.
Fixes #2076