Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_write_filter_zstd still fails on armv7 #2080

Open
lorinder opened this issue Feb 29, 2024 · 1 comment
Open

test_write_filter_zstd still fails on armv7 #2080

lorinder opened this issue Feb 29, 2024 · 1 comment

Comments

@lorinder
Copy link

I see a test failure of test_write_filter_zstd on armv7 (git HEAD). The fix for issue 1968 is applied in my tree, but I still get the out-of-memory problems. A further reduction of the search distance, as follows, solves the problem for me:

commit 089cf8e246ddafd0db5cf9f5d61f18c57229c70d
Author: Lorenz Minder <lminder@gmx.net>
Date:   Thu Feb 29 15:43:46 2024 +0000

    zstd test:  Reduce memory usage.

diff --git a/libarchive/test/test_write_filter_zstd.c b/libarchive/test/test_write_filter_zstd.c
index 04c0baa8..de7d60a3 100644
--- a/libarchive/test/test_write_filter_zstd.c
+++ b/libarchive/test/test_write_filter_zstd.c
@@ -162,7 +162,7 @@ DEFINE_TEST(test_write_filter_zstd)
 #if ZSTD_VERSION_NUMBER >= MINVER_LONG
        if ((int)(sizeof(size_t) == 4))
                assertEqualIntA(a, ARCHIVE_OK,
-                   archive_write_set_filter_option(a, NULL, "long", "26"));
+                   archive_write_set_filter_option(a, NULL, "long", "25"));
        else
                assertEqualIntA(a, ARCHIVE_OK,
                    archive_write_set_filter_option(a, NULL, "long", "27"));

The machine I was trying this on is a Raspberry Pi 3B, which has only 1GB of RAM. I would not expect this to be a problem though, as it has 6GB of swap space. It seems more likely that it's running out of address space, rather than memory itself.

$ free -h
               total        used        free      shared  buff/cache   available
Mem:           930Mi       118Mi       126Mi       320Ki       701Mi       811Mi
Swap:          5.8Gi       768Ki       5.8Gi
@lorinder
Copy link
Author

I forgot to attach the error log. Here it is:

test_write_filter_zstd.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant