expose evhttp_get_request to user

[MBeanwenshengming]

can you expose evhttp_get_request to user?

i have a listen thread and some work threads, work threads(IO thread) use evhttp_new create http server

my listen thread send socket to work threads by load, work thread use evhttp_get_request create http service(i modify it local)

i mainly use libevent for websocket.

thank you!!

[mllw]

I have the same needs

[azat]

@MBeanwenshengming I'm not sure that it worth to export this internal function, so is there any reason for not using multiple http servers per-thread with SO_REUSEPORT?

[mllw]

Before using the http protocol, I need to detect the other network protocols.

[azat]

@widgetii what do you think about exporting this function?

[MBeanwenshengming]

@azat My needs are essentially the same with mllw, export evhttp_get_request to user, It can make the user more flexible. thanks!
our server use libevent for tcp too.

[widgetii]

@widgetii what do you think about exporting this function?

I have no objections personally if it helps to our library users

[azat]

Ok, let's do this. And since we have a real users, @MBeanwenshengming or @mllw can you submit a pull request that will export it and also add some unit test with some real example into test/regress_http.c?

[mllw]

I added a one by one function based on 4d85d28 and patched it, now it works fine, you can simply add this patch to vcpkg to use it。

in vcpkg ports/libevent/portfile.cmake
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO libevent/libevent
REF 4d85d28
SHA512 d03daf8e2277e8b9d67e0028d05566c8972a706e53dcb6593f8f92942ff9ce814970418a10d4c37e68228ec153f8fbc7d764a7ff92e2872277a92039380cbbe9
PATCHES
fix-uwp.patch
fix-file_path.patch
fix-LibeventConfig_cmake_in_path.patch
fix-usage.patch
http_add_get.patch
)

http_add_get.patch

[mllw]

I think expose evhttp_get_request_bufferevent is better than evhttp_get_request

[MBeanwenshengming]

i just add a export function to http.h

EVENT2_EXPORT_SYMBOL
void evhttp_get_request_app(struct evhttp http, evutil_socket_t fd,
struct sockaddr sockaddr, ev_socklen_t sockaddrlen, struct bufferevent *bev);

add the following code to http.c

void evhttp_get_request_app(struct evhttp* http, evutil_socket_t fd,
struct sockaddr* sockaddr, ev_socklen_t sockaddrlen,
struct bufferevent* bev)
{
evhttp_get_request(http, fd, sockaddr, sockaddrlen, bev);
}

I'm not very familiar with libevent

but the code can work

i just want to call evhttp_get_request

[azat]

We heed to have unit test as well.