Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MbedTLS and ZLIB for windows on CI #1534

Open
azat opened this issue Jan 6, 2024 · 1 comment
Open

Fix MbedTLS and ZLIB for windows on CI #1534

azat opened this issue Jan 6, 2024 · 1 comment

Comments

@azat
Copy link
Member

azat commented Jan 6, 2024

Now it failed for export tests:

CMake Error at C:/Program Files/CMake/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:230 (message):                                                                                                
Error:   Could NOT find MbedTLS (missing: MBEDTLS_INCLUDE_DIR MBEDTLS_LIBRARY                                                                                                                                    
  MBEDTLS_CRYPTO_LIBRARY MBEDTLS_X509_LIBRARY MBEDTLS_LIBRARIES                                                                                                                                                  
  MBEDTLS_VERSION)                                                                                                                                                                                               
Call Stack (most recent call first):                                                                                                                                                                             
  C:/Program Files/CMake/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)                                                                                               
  D:/a/libevent/libevent/cmake/FindMbedTLS.cmake:142 (find_package_handle_standard_args)                                                                                                                         
  D:/a/libevent/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package)                                                                                                                                       
  C:/Program Files/CMake/share/cmake-3.27/Modules/CMakeFindDependencyMacro.cmake:76 (find_package)                                                                                                               
  D:/a/libevent/libevent/build/LibeventConfig.cmake:43 (find_dependency)                                                                                                                                         
  D:/a/libevent/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package)                                                                                                                                       
  CMakeLists.txt:11 (find_package)                                                                                                                                                                               

But it is not a fatal error on some builds:

-- OpenSSL lib: optimized;C:/Program Files/OpenSSL/lib/VC/libssl64MD.lib;debug;C:/Program Files/OpenSSL/lib/VC/libssl64MDd.lib;optimized;C:/Program Files/OpenSSL/lib/VC/libcrypto64MD.lib;debug;C:/Program Files/OpenSSL/lib/VC/libcrypto64MDd.lib                                                                                                                                                                                   
-- Could NOT find MbedTLS (missing: MBEDTLS_INCLUDE_DIR MBEDTLS_LIBRARY MBEDTLS_CRYPTO_LIBRARY MBEDTLS_X509_LIBRARY MBEDTLS_LIBRARIES MBEDTLS_VERSION)·                                                          
-- Could NOT find ZLIB (missing: ZLIB_LIBRARY) (found version "1.2.11")                                                                                                                                          
azat added a commit that referenced this issue Jan 6, 2024
But note, that there is still issues with MbedTLS and ZLIB:

    CMake Error at C:/Program Files/CMake/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
    Error:   Could NOT find MbedTLS (missing: MBEDTLS_INCLUDE_DIR MBEDTLS_LIBRARY
      MBEDTLS_CRYPTO_LIBRARY MBEDTLS_X509_LIBRARY MBEDTLS_LIBRARIES
      MBEDTLS_VERSION)
    Call Stack (most recent call first):
      C:/Program Files/CMake/share/cmake-3.27/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
      D:/a/libevent/libevent/cmake/FindMbedTLS.cmake:142 (find_package_handle_standard_args)
      D:/a/libevent/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
      C:/Program Files/CMake/share/cmake-3.27/Modules/CMakeFindDependencyMacro.cmake:76 (find_package)
      D:/a/libevent/libevent/build/LibeventConfig.cmake:43 (find_dependency)
      D:/a/libevent/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
      CMakeLists.txt:11 (find_package)

But by some reason it is not a fatal error on some builds:

    -- OpenSSL lib: optimized;C:/Program Files/OpenSSL/lib/VC/libssl64MD.lib;debug;C:/Program Files/OpenSSL/lib/VC/libssl64MDd.lib;optimized;C:/Program Files/OpenSSL/lib/VC/libcrypto64MD.lib;debug;C:/Program Files/OpenSSL/lib/VC/libcrypto64MDd.lib
    -- Could NOT find MbedTLS (missing: MBEDTLS_INCLUDE_DIR MBEDTLS_LIBRARY MBEDTLS_CRYPTO_LIBRARY MBEDTLS_X509_LIBRARY MBEDTLS_LIBRARIES MBEDTLS_VERSION)
    -- Could NOT find ZLIB (missing: ZLIB_LIBRARY) (found version "1.2.11")

This will be fixed separatelly - #1534, partially worked CI better then
fully broken anyway.

* ci/windows:
  Update vcpkg to fix windows CI
  Switch to windows-latest (just in case)
@azat
Copy link
Member Author

azat commented Feb 18, 2024

https://github.com/libevent/libevent/actions/runs/7949666940/job/21701087085?pr=1552

CMake Error at D:/a/libevent/libevent/build/LibeventConfig.cmake:81 (message):
Error: Your libevent library does not contain a mbedtls component!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant