MacOS CI is broken

[azat]

autotools

ld: warning: search path '/usr/local/opt/mbedtls@2/lib' not found
ld: library 'ssl' not found

cmake flaky tests

49/64 Test #49: regress__KQUEUE .....................***Failed   90.19 sec
[warn] evbuffer_file_segment_materialize: mmap(4, 0, 0) failed: Invalid argument
[Lost connection!] 1/353 TESTS FAILED. (41 skipped)

      Start 50: regress__KQUEUE_debug
50/64 Test #50: regress__KQUEUE_debug ...............***Failed   90.26 sec
[warn] evbuffer_file_segment_materialize: mmap(4, 0, 0) failed: Invalid argument
[Lost connection!] 1/353 TESTS FAILED. (41 skipped)

[Coeur]

You do:

libevent/.github/workflows/build.yml

Line 554 in 64decd4

run: brew install mbedtls@2

Then you wrongly assume the path:

libevent/.github/workflows/build.yml

Line 586 in 64decd4

EVENT_CMAKE_OPTIONS="$EVENT_CMAKE_OPTIONS -DMBEDTLS_ROOT_DIR=/usr/local/opt/mbedtls@2"

The actual path is dependent on whether the machine is Intel or Apple Silicon. On macos-latest, GitHub will now use Apple Silicon, so path should be /opt/homebrew/opt/mbedtls@2 instead. And for OpenSSL, it should be /opt/homebrew/opt/openssl

[azat]

Hm, didn't knew that github actions provides apple silicon support now (previously it was only for paid users), great!

[azat]

The issue is not fixed completely, only first steps

[Coeur]

I ran the tests locally on my Mac:

      Start 50: regress__KQUEUE
50/65 Test #50: regress__KQUEUE .....................   Passed   96.63 sec
      Start 51: regress__KQUEUE_debug
51/65 Test #51: regress__KQUEUE_debug ...............   Passed   96.81 sec

So I'm proposing an improvement in the failure message for further debugging: #1662

[Coeur]

The results of the log improvements from #1662 show that we're passing 0 to the length argument of mmap, which is not allowed: https://man7.org/linux/man-pages/man2/mmap.2.html
So backtracking, it means seg->length and seg->file_offset were both 0.

[Coeur]

@nmathewson would you know why in GitHub Actions, evbuffer_file_segment_materialize is called with length and file_offset of 0 in regress__KQUEUE, while locally on my Mac that never happens?