Fix brew path on Apple Silicon #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azat
approved these changes
Apr 29, 2024
fanquake
reviewed
Apr 30, 2024
azat
reviewed
May 1, 2024
azat
reviewed
May 1, 2024
azat
reviewed
May 1, 2024
azat
reviewed
May 1, 2024
| @@ -583,7 +580,7 @@ jobs: | |||
| else | |||
| EVENT_CMAKE_OPTIONS="" | |||
| fi | |||
| EVENT_CMAKE_OPTIONS="$EVENT_CMAKE_OPTIONS -DMBEDTLS_ROOT_DIR=/usr/local/opt/mbedtls@2" | |||
| EVENT_CMAKE_OPTIONS="$EVENT_CMAKE_OPTIONS -DMBEDTLS_ROOT_DIR=`brew --prefix mbedtls@2`" | |||
There was a problem hiding this comment.
BTW what is @2 can we adopt the detection that we have in cmake as well? (can be done separately)
There was a problem hiding this comment.
BTW what is
@2
The @2 forces the version 2 instead of version 3. It was added by #1204.
If we remove it, then we would be using mbedtls 3 instead of mbedtls 2. Yes, can be updated in a separate PR.
can we adopt the detection that we have in cmake as well?
Maybe. But also for a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1632