Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected input(s) 'vcpkgArguments', 'vcpkgTriplet' #1648

Closed
Coeur opened this issue May 5, 2024 · 2 comments · Fixed by #1657
Closed

Unexpected input(s) 'vcpkgArguments', 'vcpkgTriplet' #1648

Coeur opened this issue May 5, 2024 · 2 comments · Fixed by #1657

Comments

@Coeur
Copy link
Contributor

Coeur commented May 5, 2024

windows-vs-job shows this warning:

(https://github.com/libevent/libevent/actions/runs/8949929874/job/24584751215#step:4:1)
Unexpected input(s) 'vcpkgArguments', 'vcpkgTriplet', valid inputs are ['vcpkgDirectory', 'runVcpkgInstall', 'vcpkgGitCommitId', 'vcpkgGitURL', 'doNotUpdateVcpkg', 'doNotCache', 'vcpkgJsonGlob', 'vcpkgJsonIgnores', 'vcpkgConfigurationJsonGlob', 'binaryCachePath', 'runVcpkgFormatString', 'useShell', 'logCollectionRegExps']

This may be a result from 3e01178 which updated the job while leaving the existing inputs?
I do not know the replacements for 'vcpkgArguments' and 'vcpkgTriplet'.

Current action looks like that:

- name: Prepare vcpkg
uses: lukka/run-vcpkg@v11
id: runvcpkg
with:
vcpkgArguments: zlib:x64-windows openssl:x64-windows mbedtls:x64-windows
vcpkgDirectory: ${{ runner.workspace }}/vcpkg/
vcpkgTriplet: x64-windows
vcpkgGitCommitId: c8696863d371ab7f46e213d8f5ca923c4aef2a00 # 2023.12.12

@fanquake
Copy link
Contributor

fanquake commented May 9, 2024

@hebasto you might have an idea?

@hebasto
Copy link
Contributor

hebasto commented May 10, 2024

The lukka/run-vcpkg versions newer than v7 expect a vcpkg manifest file.

The most direct fix is to revert its version back to v7. The concerns expressed in 3e01178 are supposedly mitigated in the recent v7.6 release.

The other option is to introduce a vcpkg.json manifest file.

azat added a commit to azat/libevent that referenced this issue May 18, 2024
windows-vs-job shows this warning:

    >(https://github.com/libevent/libevent/actions/runs/8949929874/job/24584751215#step:4:1)
    Unexpected input(s) 'vcpkgArguments', 'vcpkgTriplet', valid inputs are ['vcpkgDirectory', 'runVcpkgInstall', 'vcpkgGitCommitId', 'vcpkgGitURL', 'doNotUpdateVcpkg', 'doNotCache', 'vcpkgJsonGlob', 'vcpkgJsonIgnores', 'vcpkgConfigurationJsonGlob', 'binaryCachePath', 'runVcpkgFormatString', 'useShell', 'logCollectionRegExps']

Let's simply revert to the last working version, thanks to @hebasto, @Coeur

Fixes: libevent#1648
This reverts commit 3e01178.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants