Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add php to CI #765

Open
pierrejoye opened this issue Sep 13, 2021 · 4 comments
Open

add php to CI #765

pierrejoye opened this issue Sep 13, 2021 · 4 comments

Comments

@pierrejoye
Copy link
Contributor

Add build and run php tests to our CI

  • 7.4, 8.0 and 8.1 for 2.3
  • 8.0 up for 2.4+
@cmb69
Copy link
Contributor

cmb69 commented Sep 13, 2021

I'm not sure whether this is a good idea; at least we shouldn't run that for each commit, but rather nightly or so. An alternative would be to do that for php-src.

@pierrejoye
Copy link
Contributor Author

pierrejoye commented Sep 13, 2021 via email

@cmb69
Copy link
Contributor

cmb69 commented Sep 13, 2021

Yeah, but there may be a performance issue. Currently our CI is quite fast (a few minutes); building php-src and runnings its gd test suite certainly takes longer. And while php-src might be our most important downstream consumer, there are certainly others as well.

PS: I hate slow CI.

@pierrejoye
Copy link
Contributor Author

pierrejoye commented Sep 13, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants