-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add php to CI #765
Comments
I'm not sure whether this is a good idea; at least we shouldn't run that for each commit, but rather nightly or so. An alternative would be to do that for php-src. |
I am not sure :)
My thoughts were to have it run vs released php versions, including rc if
we like to.
Open for scheduled runs but I do like to know if something breaks on
commit, not too much later. :)
…On Mon, Sep 13, 2021, 7:13 PM Christoph M. Becker ***@***.***> wrote:
I'm not sure whether this is a good idea; at least we shouldn't run that
for each commit, but rather nightly or so. An alternative would be to do
that for php-src.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#765 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACE6KCLTTQ7QZU7UGAY7VTUBXTHBANCNFSM5D5S5GMA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Yeah, but there may be a performance issue. Currently our CI is quite fast (a few minutes); building php-src and runnings its gd test suite certainly takes longer. And while php-src might be our most important downstream consumer, there are certainly others as well. PS: I hate slow CI. |
it runs in parallel. Let me try with a schedule and see how long it takes.
--disable-all with gd should not be that big hopefully :)
…On Mon, Sep 13, 2021, 8:34 PM Christoph M. Becker ***@***.***> wrote:
Yeah, but there may be a performance issue. Currently our CI is quite fast
(a few minutes); building php-src and runnings its gd test suite certainly
takes longer. And while php-src might be our most important downstream
consumer, there are certainly others as well.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#765 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACE6KFZPH4DT4INOUJDNRLUBX4VZANCNFSM5D5S5GMA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Add build and run php tests to our CI
The text was updated successfully, but these errors were encountered: