Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

Failed to get TCP info getsockopt: not implemented #106

Closed
prestonvanloon opened this issue Oct 4, 2021 · 3 comments
Closed

Failed to get TCP info getsockopt: not implemented #106

prestonvanloon opened this issue Oct 4, 2021 · 3 comments

Comments

@prestonvanloon
Copy link

After updating prysm to a recent version of libp2p, many users are reporting this log. It seems to have something to do with metrics and it is a cause for concern.

Failed to get TCP info: raw-control tcp 10.0.0.2:13000: getsockopt: not implemented

It seems to be coming from this line: https://github.com/libp2p/go-tcp-transport/blob/v0.2.4/metrics.go#L135

How can we disable this metrics collection?
What is this log about?

Tracking in Prysm here: prysmaticlabs/prysm#9733

@prestonvanloon
Copy link
Author

I noticed this seems to be a windows only issue, but this issue gives us a bit of concern.
Metrics collection have additional overhead, complexity, and side effects / bugs.
How can we disable metrics collection entirely for go-tcp-transport?

@aschmahmann
Copy link

aschmahmann commented Oct 5, 2021

Closed by #93 which is in https://github.com/libp2p/go-tcp-transport/releases/tag/v0.2.8.

As for the more general "how do I disable metrics" question I'll defer to @marten-seemann and if you'd like you can open a new issue.

However, IIRC in this particular case the only way to trigger this error message on Windows is if you explicitly called the prometheus metrics collection.

@marten-seemann
Copy link
Contributor

Metrics collection can currently not be disabled, as for all other libp2p / IPFS systems. So far, I haven't seen any benchmark that showed a significant performance impact of metrics collection in our stack (but I can be convinced otherwise by data).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants