Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove deprecated multihashes library #2522

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

fix: remove deprecated multihashes library #2522

wants to merge 10 commits into from
+39 −30

Conversation

maschad
Copy link
Member

@maschad maschad commented May 2, 2024 •
edited

Closes #2264

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@maschad maschad requested a review from a team as a code owner May 2, 2024 23:22
@maschad maschad self-assigned this May 2, 2024
@maschad maschad added the dependencies Pull requests that update a dependency file label May 2, 2024
@maschad maschad marked this pull request as draft May 2, 2024 23:24
@maschad maschad marked this pull request as ready for review May 2, 2024 23:26
@dhuseby dhuseby mentioned this pull request May 7, 2024
Open
@achingbrain
Copy link
Member

@maschad the interop tests are failing but pass against main - it might be actual breakage, can you take a look please?

@achingbrain achingbrain self-requested a review May 14, 2024 11:03
achingbrain
achingbrain requested changes May 14, 2024
View reviewed changes
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but CI is failing so needs investigating/fixing before merge.

@maschad maschad marked this pull request as draft May 14, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achingbrain achingbrain achingbrain requested changes

Assignees

@maschad maschad

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deps: @libp2p/webrtc depends on deprecated packages
2 participants
@maschad @achingbrain