Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ConnectionResetError test case #376

Open
NIC619 opened this issue Dec 5, 2019 · 1 comment
Open

Add ConnectionResetError test case #376

NIC619 opened this issue Dec 5, 2019 · 1 comment

Comments

@NIC619
Copy link
Contributor

NIC619 commented Dec 5, 2019

What was wrong?

We don't have test that check if ConnectionResetError is properly handled

How can it be fixed?

Add test that triggers ConnectionResetError and check if read/write in RawConnection handle the error as expected.
@ChihChengLiang
Copy link
Contributor

ChihChengLiang commented Dec 5, 2019 •
edited

As a side note, the issue is a followup of a bug of Trinity ethereum/trinity#1113. The bug was assumed to be resolved in #293 and the related PRs, but the symptom still exists now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChihChengLiang @NIC619